Skip to content

Add document listing supported feature checks - #94440

Merged
sbomer merged 5 commits into
dotnet:mainfrom
sbomer:featureChecksDoc
Nov 14, 2023
Merged

sbomer merged 5 commits into
dotnet:mainfrom
sbomer:featureChecksDoc

Conversation

@sbomer

@sbomer sbomer commented Nov 6, 2023

Copy link
Copy Markdown
Member

The ILLink roslyn analyzer, ILLink, and ILCompiler all support different forms of branch removal and constant propagation. This document is meant to describe the supported/recommended patterns that should work with all of these tools. Related to the discussion in dotnet/linker#2715.

@ghost ghost added linkable-framework Issues associated with delivering a linker friendly framework area-Tools-ILLink .NET linker development as well as trimming analyzers labels Nov 6, 2023
@ghost ghost assigned sbomer Nov 6, 2023
@ghost

ghost commented Nov 6, 2023

Copy link
Copy Markdown

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

The ILLink roslyn analyzer, ILLink, and ILCompiler all support different forms of branch removal and constant propagation. This document is meant to describe the supported/recommended patterns that should work with all of these tools. Related to the discussion in dotnet/linker#2715.

Author: sbomer
Assignees: -
Labels:

linkable-framework

Milestone: -

@vitek-karas vitek-karas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you checked we have tests for each of these cases and that they behave as described here :-)

Looks good, thanks for writing this down.

@sbomer
sbomer requested a review from marek-safar as a code owner November 14, 2023 00:26
@sbomer

sbomer commented Nov 14, 2023

Copy link
Copy Markdown
Member Author

Added a testcase for the early return case which I missed earlier. Everything else is already covered.

@MichalStrehovsky MichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing it down.

Depending on who the target audience is, should we also say that yield/async/etc state machines also break all of this outside the analyzer?

@sbomer
sbomer merged commit 543c7a5 into dotnet:main Nov 14, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 15, 2023
@sbomer
sbomer deleted the featureChecksDoc branch June 26, 2026 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants